Skip to content

fix: avoid IndexOutOfBoundsException in enhanced selection #126

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2025
Merged

fix: avoid IndexOutOfBoundsException in enhanced selection #126

merged 1 commit into from
Mar 11, 2025

Conversation

javier-godoy
Copy link
Member

@javier-godoy javier-godoy commented Mar 11, 2025 •
edited by coderabbitai bot
Loading

Close #125.

dataView.getItem intentionally throws if the index is out of bounds, and newFocusedItemIndex happens to be 0 in the scenario proposed in the issue.

Summary by CodeRabbit

  • Refactor
    • Enhanced the grid’s selection handling for smoother and more reliable navigation through item lists. This update improves the accuracy of item focus, ensuring that interactions remain consistent even in edge-case scenarios during data exploration.

@javier-godoy javier-godoy requested review from mlopezFC and paodb March 11, 2025 17:49
@coderabbitai coderabbitai
Copy link

coderabbitai bot commented Mar 11, 2025 •
edited
Loading

Walkthrough

The change modifies the logic for determining the new focused item in the enableEnhancedSelection method. Instead of retrieving an item by index using dataView.getItem(newFocusedItemIndex) wrapped in an Optional, it now uses the stream API to skip a given number of items and then finds the first remaining item using dataView.getItems().skip(newFocusedItemIndex).findFirst(). No changes were made to any exported or public entities.

Changes

File(s) Change Summary
src/.../EnhancedSelectionGridHelper.java In the enableEnhancedSelection method, the assignment of newFocusedItemMaybe was modified from using Optional.ofNullable(dataView.getItem(newFocusedItemIndex)) to using dataView.getItems().skip(newFocusedItemIndex).findFirst().
📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1ba8a67 and 926a88c.

📒 Files selected for processing (1)
  • src/main/java/com/flowingcode/vaadin/addons/gridhelpers/EnhancedSelectionGridHelper.java (2 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: build-vaadin24
🔇 Additional comments (1)
src/main/java/com/flowingcode/vaadin/addons/gridhelpers/EnhancedSelectionGridHelper.java (1)

113-113: Good fix to prevent IndexOutOfBoundsException.

The change from directly accessing an item by index to using the stream API is an excellent solution for preventing the IndexOutOfBoundsException mentioned in the PR description. Using skip() and findFirst() ensures that even if newFocusedItemIndex is valid but beyond the available data bounds, the code will gracefully handle it by returning an empty Optional rather than throwing an exception.

✨ Finishing Touches
  • 📝 Generate Docstrings

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@paodb paodb merged commit d6e8fec into master Mar 11, 2025
5 checks passed
@github-project-automation github-project-automation bot moved this from In Progress to Pending release in Flowing Code Addons Mar 11, 2025
@paodb paodb deleted the fix-125 branch March 11, 2025 19:45
@javier-godoy javier-godoy moved this from Pending release to Done in Flowing Code Addons Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@paodb paodb paodb approved these changes

@mlopezFC mlopezFC Awaiting requested review from mlopezFC

Assignees
No one assigned
Labels
None yet
Projects
Flowing Code Addons
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Enhanced selection throws IndexOutOfBoundsException in grid with filterable column
2 participants
@javier-godoy @paodb